[PATCH] D49979: [llvm-objcopy] Add --dump-section

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 2 06:19:10 PDT 2018


jhenderson added a comment.

In https://reviews.llvm.org/D49979#1184977, @jakehehrlich wrote:

> Due to the soon encroaching change where `-I binary` will be implemented I'm very much in favor of the OriginalData field being added to SectionBase. Really seems to handle everything very cleanly IMO.


Okay, go for it. I have nerves around lifetime issues with references like that, but I think the structure means that the Reader (and therefore the file it reads) will be around long enough for it to not matter.


Repository:
  rL LLVM

https://reviews.llvm.org/D49979





More information about the llvm-commits mailing list