[PATCH] D49981: [InstSimplify] fold extracting from std::pair (2/2)

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.

LGTM - see inline for some typo fixes.



================
Comment at: lib/Analysis/InstructionSimplify.cpp:1874-1875
+  //     if Mask = ((1 << effective_width_of(X)) - 1) << A
+  // SimplifyDemandedBits in InstCombine can optimization general case.
+  // This pattern aims to help other optimizers for a common case.
+  Value *Y, *XShifted;
----------------
optimization -> optimize the
optimizers -> passes


================
Comment at: test/Transforms/InstSimplify/AndOrXor.ll:995
 
 ; concatinate two 32-bit integers and extract lower 32-bit
 define i64 @shl_or_and3(i32 %a, i32 %b) {
----------------
Here and below: concatinate -> concatenate


https://reviews.llvm.org/D49981