[PATCH] D49926: Update split stack support to handle more generic prologues.Improve error handling.Add test file for better code-coverage. Update tests to be morecomplete.

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.

LGTM.



================
Comment at: test/ELF/x86-64-split-stack-prologue-adjust-fail.s:14
 
+# RUN: not ld.lld --defsym __morestack=0x100 --defsym _start=0x300 %t1.o %t2.o %t3.o -o %t 2>&1 | FileCheck %s -check-prefix=UNDEFINED_MORE_STACK_NON_SPLIT
+# UNDEFINED_MORE_STACK_NON_SPLIT: Mixing split-stack objects requires a definition of __more_stack_non_split
----------------
saugustine wrote:
> grimar wrote:
> > Do you need the --defsym here?
> > 
> > I would also rename `UNDEFINED_MORE_STACK_NON_SPLIT` so something a bit shorter. Maybe just `ERROR`?
> Don't need the defsym, because this test is testing what happens when it has been omitted.
> 
> Renamed to just ERROR.
I was mean you probably do not need passing `--defsym __morestack=0x100 --defsym _start=0x300` here.




Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49926