[PATCH] D50169: [XRay] Improve error reporting when loading traces (NFC)

[Dean Michael Berris via Phabricator via llvm-commits]

dberris created this revision.
dberris added reviewers: kpw, eizan.
Herald added a subscriber: hiraditya.

This change uses a single offset pointer used throughout the
implementation of the individual record parsers. This allows us to
report where in a trace file parsing failed.

We're still in an intermediate step here as we prepare to refactor this
further into a set of types and use object-oriented design principles
for a cleaner implementation. The next steps will be to allow us to
parse/dump files in a streaming fashion and incrementally build up the
structures in memory instead of the current all-or-nothing approach.


https://reviews.llvm.org/D50169

Files:
  llvm/lib/XRay/Trace.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50169.158682.patch
Type: text/x-patch
Size: 34519 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180802/fae56db3/attachment.bin>