[PATCH] D49395: [WebAssembly] Support for atomic.wait / atomic.wake instructions

[Derek Schuff via Phabricator via llvm-commits]

dschuff added a comment.

I would imagine that's already on Ben's plate to do sometime, but yes it should be changed to match JS.



================
Comment at: include/llvm/IR/IntrinsicsWebAssembly.td:75
+  Intrinsic<[llvm_i32_ty],
+            [LLVMPointerType<llvm_i32_ty>, llvm_i32_ty, llvm_i64_ty],
+            [IntrInaccessibleMemOrArgMemOnly, ReadOnly<0>, NoCapture<0>,
----------------
aheejin wrote:
> dschuff wrote:
> > Same signature adjustments as suggested in the clang CL. 
> I added some [[ https://reviews.llvm.org/D49396#inline-440755 | comments ]] in that CL, PTAL.
Yeah, so this signature would be unchanged then, since there's no signed/unsigned distinction in the IR either.


Repository:
  rL LLVM

https://reviews.llvm.org/D49395