[PATCH] D49950: [Polly][JSONExporter] Replace bundled Jsoncpp with LLVM's JSON.h. NFC.
Huihui Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 1 16:28:39 PDT 2018
huihuiz added a comment.
if (!ParseResult) {
ParseResult.takeError();
errs() << "JSCoP file could not be parsed\n";
return false;
}
json::Object &jscop = *ParseResult.get().getAsObject();
What are you doing with the result of takeError()? Isn't this causing warn_unused_result build failure?
How could you tell the difference between success and failure? If ParseResult is null value, how could you call takeError() from it?
Repository:
rL LLVM
https://reviews.llvm.org/D49950
More information about the llvm-commits
mailing list