[PATCH] D49926: Update split stack support to handle more generic prologues.Improve error handling.Add test file for better code-coverage. Update tests to be morecomplete.
Sterling Augustine via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 1 16:26:12 PDT 2018
saugustine added a comment.
Thanks.
================
Comment at: ELF/Arch/X86_64.cpp:490
// with "stc, nopl 0x0(%rax,%rax,1)"
- if (Loc + 8 < End && memcmp(Loc, "\x64\x48\x3b\x24\x25", 4) == 0) {
+ if (memcmp(Loc, "\x64\x48\x3b\x24\x25", 4) == 0) {
memcpy(Loc, "\xf9\x0f\x1f\x84\x00\x00\x00\x00", 8);
----------------
ruiu wrote:
> This looks odd -- you passed a 5 byte string and then specify 4.
Miscount from when I changed it from sizeof.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D49926
More information about the llvm-commits
mailing list