[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi added a comment.

In https://reviews.llvm.org/D49678#1184913, @jakehehrlich wrote:

> I think I'd like to make a recommendation that we implement compression first and then decompression next.


The decompression implementation is going to be pretty minimal. Decompressor.cpp/h is already in the tree. That is unless you think we need to also add some kind of DecompressedDebugSection class type?



================
Comment at: include/llvm/Object/Compressor.h:39
+
+template <>
+void produceCompressedZLibHeader<object::ELF64LE>(support::endian::Writer &W,
----------------
jakehehrlich wrote:
> None of these specializations should exist. As far as I can tell they all do the same thing anyway.
The specializations just call the non-specialized version of produceCompressedZLibHeader with either Elf64_Chdr or Elf32_Chdr. I could replace this with a runtime check.


Repository:
  rL LLVM

https://reviews.llvm.org/D49678