[PATCH] D48899: [dsymutil] Convert recursion in lookForDIEsToKeep into worklist.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/trunk/tools/dsymutil/DwarfLinker.cpp:760
+namespace {
+/// This class represents an item in the work list. In addition to it's obvious
+/// purpose of representing the state associated with a particular run of the
----------------
nit, its


================
Comment at: llvm/trunk/tools/dsymutil/DwarfLinker.cpp:772
+  bool IsContinuation;
+  CompileUnit::DIEInfo *ChildInfo = nullptr;
+
----------------
Could reducing WorklistItem's size improve the performance at all? If so, would packing Flags and IsContinuation into a bitfield and storing the child's DIEIndex be a way of accomplishing that?


Repository:
  rL LLVM

https://reviews.llvm.org/D48899