[test-suite] r338626 - cmake: Remove unused TARGET_VAR arg from llvm_singlesource()

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 1 13:22:36 PDT 2018


Author: matze
Date: Wed Aug  1 13:22:36 2018
New Revision: 338626

URL: http://llvm.org/viewvc/llvm-project?rev=338626&view=rev
Log:
cmake: Remove unused TARGET_VAR arg from llvm_singlesource()

Modified:
    test-suite/trunk/Bitcode/simd_ops/CMakeLists.txt
    test-suite/trunk/cmake/modules/SingleMultiSource.cmake

Modified: test-suite/trunk/Bitcode/simd_ops/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/Bitcode/simd_ops/CMakeLists.txt?rev=338626&r1=338625&r2=338626&view=diff
==============================================================================
--- test-suite/trunk/Bitcode/simd_ops/CMakeLists.txt (original)
+++ test-suite/trunk/Bitcode/simd_ops/CMakeLists.txt Wed Aug  1 13:22:36 2018
@@ -21,6 +21,6 @@ foreach(sourcebc ${uosources})
   string(REPLACE "." "" namebc ${namebc})
   set(Source ${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_halide_runtime.bc ${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_tests/${namebc}.bc ${CMAKE_CURRENT_SOURCE_DIR}/${ARCH}_scalar_tests/scalar_${namebc}.bc)
   set(PROG simd_ops_${namebc})
-  llvm_multisource(TARGET_VAR _target)
-  target_link_libraries(${_target} simd_ops)
+  llvm_multisource()
+  target_link_libraries(${PROG} simd_ops)
 endforeach()

Modified: test-suite/trunk/cmake/modules/SingleMultiSource.cmake
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/cmake/modules/SingleMultiSource.cmake?rev=338626&r1=338625&r2=338626&view=diff
==============================================================================
--- test-suite/trunk/cmake/modules/SingleMultiSource.cmake (original)
+++ test-suite/trunk/cmake/modules/SingleMultiSource.cmake Wed Aug  1 13:22:36 2018
@@ -7,19 +7,17 @@
 #
 # Defines helpers to add executables and tests. The entry points to this
 # file are:
-#   `llvm_singlesource([PREFIX p] [TARGET_VAR VarName])`, and
+#   `llvm_singlesource([PREFIX p])`, and
 #   `llvm_multisource()`
 #
 # Following convenience macros provide shortcuts for common test cases:
 #
-# llvm_singlesource([PREFIX p] [TARGET_VAR VarName])
+# llvm_singlesource([PREFIX p])
 #
 #   Invokes llvm_test_executable() for each c/c++ source file.  If
 #   'sources is emptyno sources are specified, creates test executables
 #   for all C/C++ files in current directory.
 #   Passes optional PREFIX parameter to llvm_test_executable().
-#   If optional TARGET_VAR is specified, the variable is set to
-#   list of all created targets.
 #
 # llvm_multisource()
 #   Invokes llvm_test_executable(${PROG} [sources...])
@@ -31,7 +29,7 @@ include(TestSuite)
 # Configure the current directory as a SingleSource subdirectory - i.e. every
 # file in *.{c,cpp,cc} is treated as its own test.
 macro(llvm_singlesource)
-  cmake_parse_arguments(_LSARG "" "PREFIX;TARGET_VAR" "" ${ARGN})
+  cmake_parse_arguments(_LSARG "" "PREFIX" "" ${ARGN})
   if(DEFINED Source)
     set(sources ${Source})
   else()
@@ -42,9 +40,6 @@ macro(llvm_singlesource)
     llvm_test_traditional(${name})
     set(_target ${_LSARG_PREFIX}${name})
     llvm_test_executable(${_target} ${source})
-    if(_LSARG_TARGET_VAR)
-      list(APPEND ${_LSARG_TARGET_VAR} ${_target}})
-    endif()
   endforeach()
 endmacro()
 




More information about the llvm-commits mailing list