[PATCH] D50021: [Support] Add casting iterator adapters

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: include/llvm/Support/CastingIterators.h:39
+    if (auto *Derived = dyn_cast<DerivedT>(Base))
+      return (Derived->*Acceptable)();
+    return false;
----------------
I'd probably skip this extra generality of providing an extra predicate on top of the isa/dyn_cast filter. Users can implement that with another filtering iterator if needed.


https://reviews.llvm.org/D50021