[PATCH] D46021: [DEBUGINFO] Disable emission of the dwarf sections, but allow directives.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2145
+  if (llvm::all_of(CUMap,
+                   [](const decltype(CUMap)::const_iterator::value_type &Pair) {
+                     return Pair.second->getCUNode()->getEmissionKind() ==
----------------
Could simplify this by dropping the "::const_iterator":

  [](const decltype(CUMap)::value_type &Pair) {


================
Comment at: test/DebugInfo/Generic/directives-only.ll:4
+; Check that the assembly output properly handles is_stmt changes. And since
+; we're testing anyway, check the integrated assembler too.
+
----------------
Is the integrated assembler tested here? Doesn't immediately look like it to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D46021