[PATCH] D50145: [MS Demangler] Demangle templated operator overloads

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 1 10:35:36 PDT 2018


ruiu added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:276
+  // Name flags.
+  NameFlags Flags;
 
----------------
I don't see a clear benefit of using bit flags for these attributes. Why don't you use two boolean flags?


https://reviews.llvm.org/D50145





More information about the llvm-commits mailing list