[PATCH] D49395: [WebAssembly] Support for atomic.wait / atomic.wake instructions

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

Do you think we should also suggest to change `wake` to `notify` in the thread proposal <https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md>?



================
Comment at: include/llvm/IR/IntrinsicsWebAssembly.td:75
+  Intrinsic<[llvm_i32_ty],
+            [LLVMPointerType<llvm_i32_ty>, llvm_i32_ty, llvm_i64_ty],
+            [IntrInaccessibleMemOrArgMemOnly, ReadOnly<0>, NoCapture<0>,
----------------
dschuff wrote:
> Same signature adjustments as suggested in the clang CL. 
I added some [[ https://reviews.llvm.org/D49396#inline-440755 | comments ]] in that CL, PTAL.


Repository:
  rL LLVM

https://reviews.llvm.org/D49395