[PATCH] D50052: [LLD] Improve handling of AT> linker script commands

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I think it is fine (with minor nit). I would wait for the landing of the https://reviews.llvm.org/D50133 first though. It might affect the code of this patch perhaps I think.



================
Comment at: ELF/Writer.cpp:1826
+          (Sec->LMARegion && (Sec->LMARegion != Load->FirstSec->LMARegion))) &&
+         Load->LastSec != Out::ProgramHeaders) ||
         Sec->MemRegion != Load->FirstSec->MemRegion || Flags != NewFlags) {
----------------
The comment above needs an update.


https://reviews.llvm.org/D50052