[PATCH] D49676: [DWARF] support for .debug_addr (consumer)

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 1 02:38:55 PDT 2018


jhenderson added a comment.

In https://reviews.llvm.org/D49676#1183890, @vleschuk wrote:

> Closed by https://reviews.llvm.org/rL338447


Hi @vleschuk, you didn't address my final comments before committing this, as far as I can see. Please could you go back and fix them.

Additionally, please remember to follow the guidelines at https://llvm.org/docs/Phabricator.html#committing-a-change when committing a change reviewed via Phabricator, specifically the bit about "Differential Revision" as that auto-closes the review and syncs up the diff.


https://reviews.llvm.org/D49676





More information about the llvm-commits mailing list