[PATCH] D50077: [LLD][ELF][ARM] Add support for Armv5 and Armv6 compatible Thunks
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 1 01:41:03 PDT 2018
grimar added a comment.
I am not an expert in ARM, so have only a style comments/questions.
================
Comment at: ELF/Thunks.cpp:622
+ }
+ fatal("unrecognized relocation type");
+}
----------------
Does it make sense to include the file name and/or at least relocation value in this error message?
================
Comment at: ELF/Thunks.cpp:646
+ // currently implemented.
+ fatal("Thunks not supported for Architecture Armv6-m");
+ }
----------------
Is it possible to test this error?
Also, `Thunks` should be lower case (and perhaps `Architecture` too).
https://reviews.llvm.org/D50077
More information about the llvm-commits
mailing list