[PATCH] D49341: [test-suite] Added Image Processing Kernels Using Benchmark Library: Blur Algorithms

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 18:23:41 PDT 2018


Meinersbur added inline comments.


================
Comment at: MicroBenchmarks/ImageProcessing/Blur/main.cpp:156-157
+void BENCHMARK_gaussianBlurKernel(benchmark::State &state) {
+
+
+  int height = state.range(0);
----------------
[nit] empty lines


================
Comment at: MicroBenchmarks/ImageProcessing/Blur/main.cpp:175-177
+  if (state.range(0) == 20) {
+    saveImage(outputImage, (const char *)"testFailed.txt", height, width);
+  }
----------------
@dberris Would `::benchmark::ClobberMemory()` be a viable alternative?


https://reviews.llvm.org/D49341





More information about the llvm-commits mailing list