[PATCH] D50105: Allow oformat option to accept elf format

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 14:37:47 PDT 2018


ruiu added inline comments.


================
Comment at: lld/test/ELF/oformat-elf.s:7
+# CHECK: 0000000 7f 45 4c 46 02 01 01 00 00 00 00 00 00 00 00 00
+# CHECK: 0010000 90 11 22 cc cc cc cc cc cc cc cc cc cc cc cc cc
+
----------------
I don't think you have to verify the output because `-oformat elf` is essentially ignored. Please add one test line like this

  # RUN: ld.lld -o /dev/null %t --oformat elf

to `oformat-binary.s` to verify that the command succeeds to complete.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50105





More information about the llvm-commits mailing list