[PATCH] D45784: [DEBUG_INFO, NVPTX] Fix relocation info.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 13:35:53 PDT 2018


On Tue, Jul 31, 2018 at 6:23 AM Alexey Bataev <a.bataev at outlook.com> wrote:

> It requires .loc directive with fileref, line number and column number.
> Seems to me, line number and column number can be zeroed.
>
> The function starting label is used to evaluate function relocation info
> and without this .loc directive the relocation info is incorrect. I can't
> say why it requires this directive for the initial label. All other labels
> inherit their location from the first following instruction, but not the
> very first one.
>
Aha. I can make some sense of this then.

Let's just have a separate "emit file directive" (which looks like a .loc
directive on nvptx here) as a "emit this before" rather than the full
location. I think that makes a lot of sense.

Thoughts?

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180731/c5b5c64c/attachment.html>


More information about the llvm-commits mailing list