[PATCH] D49928: [SLP] Fix PR38339: Instruction does not dominate all uses!

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 13:16:39 PDT 2018


efriedma added inline comments.


================
Comment at: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp:3119
+            Builder.SetInsertPoint(&F->getEntryBlock(),
+                                   F->getEntryBlock().getFirstInsertionPt());
           V = Builder.CreateShuffleVector(V, UndefValue::get(VecTy),
----------------
Also, you can't just stick the instruction at the beginning of the function in this case; it's illegal to hoist a reference to a canTrap() constant.


Repository:
  rL LLVM

https://reviews.llvm.org/D49928





More information about the llvm-commits mailing list