[PATCH] D50048: [Windows FS] Fall back to MoveFileEx for rename across volumes

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 12:04:35 PDT 2018


zturner added a comment.

In https://reviews.llvm.org/D50048#1183101, @pcc wrote:

> Can't we change dsymutil to create its temporary file in the same directory as the destination?


I'm not sure that's the best solution.  Even if we fix it for dsymutil, this seems to be a more general problem of LLVM not supporting cross-device renames.  We can't control where a user's temp dir will be or what drive they're running LLVM from.  So I think it's important to handle this case.


Repository:
  rL LLVM

https://reviews.llvm.org/D50048





More information about the llvm-commits mailing list