[PATCH] D50062: [UnJ] Add debug messages at to why loops are not unrolled. NFC

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 11:51:27 PDT 2018


dmgreen added a comment.

Thanks



================
Comment at: lib/Transforms/Utils/LoopUnrollAndJam.cpp:757-758
+  // outer loop
+  auto CheckInnerLoopIterationCountInvariant = [](Loop *SubLoop, Loop *OuterL,
+                                                  ScalarEvolution &SE) {
+    BasicBlock *SubLoopLatch = SubLoop->getLoopLatch();
----------------
Meinersbur wrote:
> Could we name this in respect to what it returns? E.g. `HasConsistentIterationCounts`?
There's another patch (D50063) which renames this again and pulls it out into a separate function. I'll rename it there.


================
Comment at: lib/Transforms/Utils/LoopUnrollAndJam.cpp:780
+  if (LSI.MayThrow) {
+    LLVM_DEBUG(dbgs() << "Won't unroll-and-jam; Something maythrow\n");
     return false;
----------------
xbolva00 wrote:
> may throw 
Will do


https://reviews.llvm.org/D50062





More information about the llvm-commits mailing list