[PATCH] D50083: [SelectionDAG] Make binop reduction matcher available to all targets

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAG.h:1510
+  // was not matched.
+  SDValue matchBinOpReduction(SDNode *Extract, unsigned &BinOp,
+                              ArrayRef<ISD::NodeType> CandidateBinOps);
----------------
This looks like a good thing to put in target-independent code (especially because it is matching a canonical form). We should document BinOp and CandidateBinOps here. Also. where is BinOp unsigned and CandidateBinOps is an array of ISD::NodeType? Should BinOp also be ISD::NodeType& ?


Repository:
  rL LLVM

https://reviews.llvm.org/D50083