[PATCH] D50048: [Windows FS] Fall back to MoveFileEx for rename across volumes

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 10:29:50 PDT 2018


zturner added a comment.

I don't have a strong opinion, but I wonder if it would be better to map `ERROR_NOT_SAME_DEVICE` to `errc::cross_device_link` and to map `ERROR_CALL_NOT_IMPLEMENTED` to `errc::operation_not_supported`.  Then you could just say `if (EC == errc::cross_device_link || EC == errc::operation_not_supported)`


Repository:
  rL LLVM

https://reviews.llvm.org/D50048





More information about the llvm-commits mailing list