[PATCH] D49574: [CodeGen] Fix ICE in SelectionDAG::computeKnownBits

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 08:55:09 PDT 2018


scott.linder updated this revision to Diff 158292.
scott.linder added a comment.

I noticed I had assumed AArch64 was available in the unittests, so I updated those to be skipped in the case where it isn't.

@arsenm what do you mean is impossible? These appear to be some of the first unittests for SelectionDAG, but I don't see how to test these cases without adding them. Even if there is a reason not to add them, I still can't add more IR tests for the remaining cases.


https://reviews.llvm.org/D49574

Files:
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  test/CodeGen/AMDGPU/extract-subvector-equal-length.ll
  unittests/CodeGen/CMakeLists.txt
  unittests/CodeGen/SelectionDAGTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49574.158292.patch
Type: text/x-patch
Size: 11389 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180731/fa6d0b40/attachment.bin>


More information about the llvm-commits mailing list