[PATCH] D50033: Introduce DebugCounter into DevRemPairs pass

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 07:06:20 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D50033#1181535, @george.burgess.iv wrote:

> Looks straightforward enough to me, but spatel authored this pass (and I've never touched it), so I'm going to defer to them :)
>
> Happy to commit this for you when this has an LGTM


I have the opposite problem - I don't know anything about debug counters. :)
Can you add a comment to the test file to explain what is happening there? I think we've specified that we will skip the 1st test, perform the transform on the 2nd test, and then perform no other transforms? Should there be a 4th function to verify that last case?


Repository:
  rL LLVM

https://reviews.llvm.org/D50033





More information about the llvm-commits mailing list