[PATCH] D50052: [LLD] Improve handling of AT> linker script commands

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Seems several independent bugs are fixed here. I would suggest splitting this patch to independent reviews.

(Also, an uploaded patch has no context. Please include it next time (https://llvm.org/docs/Phabricator.html#id3).)



================
Comment at: ELF/LinkerScript.cpp:120
+  // Only expand the LMARegion if it is different from MemRegion
+  if (Ctx->LMARegion && Ctx->MemRegion != Ctx->LMARegion)
     expandMemoryRegion(Ctx->LMARegion, Size, Ctx->LMARegion->Name,
----------------
Can you split this change and the corresponding test case (at8.test) to the different patch?


================
Comment at: test/ELF/linkerscript/at8.test:10
+
+REGION_ALIAS("RAM2", RAM)
+
----------------
Do you really need an alias?


================
Comment at: test/ELF/linkerscript/at8.test:13
+SECTIONS {
+
+    .text : { *(.text) } > RAM AT> RAM2
----------------
Please remove excessive empty lines here and below.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50052