[PATCH] D49993: [LLD][ELF][ARM] Implement support for Tag_ABI_VFP_args

[Peter Smith via Phabricator via llvm-commits]

peter.smith updated this revision to Diff 158205.
peter.smith added a comment.

Thanks all for the comments.

I've updated the patch with as many of the review comments addressed as possible:

- https://reviews.llvm.org/D50049 raised to add the missing enum values for Tag_ABI_VFP_args
- I've made it an error if the Tag_ABI_VFP_args contains an out of range value (I've now used VFPArgs twice so I've not inlined it). I've added a test to check we catch the illegal value.
- Comments altered according to suggestions.


https://reviews.llvm.org/D49993

Files:
  ELF/Arch/ARM.cpp
  ELF/Config.h
  ELF/InputFiles.cpp
  test/ELF/Inputs/arm-vfp-arg-base.s
  test/ELF/Inputs/arm-vfp-arg-compat.s
  test/ELF/Inputs/arm-vfp-arg-toolchain.s
  test/ELF/Inputs/arm-vfp-arg-vfp.s
  test/ELF/arm-eabi-version.s
  test/ELF/arm-tag-vfp-args-errs.s
  test/ELF/arm-tag-vfp-args-illegal.s
  test/ELF/arm-tag-vfp-args.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49993.158205.patch
Type: text/x-patch
Size: 12252 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180731/57fc83e3/attachment.bin>