[PATCH] D49499: [X86] Prefer unpckhpd over movhlps in isel for fake unary cases

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 03:34:52 PDT 2018


RKSimon added a comment.

Getting the domain switching support would be useful, even if it (initially) only gets some of the cases.



================
Comment at: lib/Target/X86/X86InstrSSE.td:831
                       Sched<[SchedWriteFShuffle.XMM]>;
   let isCommutable = 1 in
   def MOVHLPSrr : PSI<0x12, MRMSrcReg, (outs VR128:$dst),
----------------
Shouldn't it only be commutable if it has SSE2? Looking at X86InstrInfo::commuteInstructionImpl it asserts that SSE2 is available, it doesn't early out....


https://reviews.llvm.org/D49499





More information about the llvm-commits mailing list