[PATCH] D50018: SystemZ: keep AND masks before SHL i128

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 01:04:43 PDT 2018


jonpa added a comment.

> The transform is wrong whether or not the shift type is legal: ISD::SHL returns poison for out-of-range shifts

As Eli pointed out, this transformation is actually buggy! We have hit this just recently in testing and a patch is in the making. I think Uli can help here and fill in more on the details.


Repository:
  rL LLVM

https://reviews.llvm.org/D50018





More information about the llvm-commits mailing list