[PATCH] D50005: [DWARF] Basic support for producing DWARFv5 .debug_addr section

[Victor Leschuk via Phabricator via llvm-commits]

vleschuk marked 3 inline comments as done.
vleschuk added inline comments.


================
Comment at: test/DebugInfo/X86/debug_addr.ll:9
+; void foo() {
+;   return;
+; }
----------------
dblaikie wrote:
> These return statements seem unnecessary? (in the text of this comment, and in the IR of the sample - not that it'd make much of a difference)
Removed them from the comment, not sure that I understood what do you suggest to remove from IR (IR code would be the same with or without explicit return statements in C code).



================
Comment at: test/DebugInfo/X86/debug_addr.ll:24
+; DWARF4: .debug_addr contents:
+; DWARF4-NEXT: 0x00000000: Addr Section params: length = 0x00000000, version = 0x0004, addr_size = 0x04, seg_size = 0x00
+; DWARF4-NEXT: Addrs: [
----------------
dblaikie wrote:
> There's no header in debug_addr sections in DWARFv4, is there - what's this then?
> 
> Also is this consistent with the way other section contributions are described (I don't recall text like "Addr Section params" in other output - like the way those attributes are printed out like "Compile Unit: ..." rather than "Unit Section params")?
Changed it in dependency revision: https://reviews.llvm.org/D49676.


https://reviews.llvm.org/D50005