[PATCH] D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 19:38:49 PDT 2018


dblaikie added a comment.

This looks problematic - seems suspicious that the covered value is a bool member of DILocation, but nothing else is - everything else is stored in the metadata proper. Is there a good reason for that? (it provably doesn't need to be serialized? Could this be stored as side-data in a map in an analysis instead?)

I couldn't quite spot it - where's the code that sets or constructs a DILocation with covered = true?


Repository:
  rL LLVM

https://reviews.llvm.org/D49915





More information about the llvm-commits mailing list