[llvm] r338342 - [X86] Stop accidentally running the Bonnell LEA fixup path on Goldmont.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 17:43:54 PDT 2018


Author: ctopper
Date: Mon Jul 30 17:43:54 2018
New Revision: 338342

URL: http://llvm.org/viewvc/llvm-project?rev=338342&view=rev
Log:
[X86] Stop accidentally running the Bonnell LEA fixup path on Goldmont.

In one place we checked X86Subtarget.slowLEA() to decide if the pass should run. But to decide what the pass should we only check isSLM. This resulted in Goldmont going down the Bonnell path.

Modified:
    llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp
    llvm/trunk/test/CodeGen/X86/atom-fixup-lea2.ll

Modified: llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp?rev=338342&r1=338341&r2=338342&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp Mon Jul 30 17:43:54 2018
@@ -578,7 +578,7 @@ bool FixupLEAPass::processBasicBlock(Mac
         continue;
 
     if (OptLEA) {
-      if (MF.getSubtarget<X86Subtarget>().isSLM())
+      if (MF.getSubtarget<X86Subtarget>().slowLEA())
         processInstructionForSLM(I, MFI);
 
       else {

Modified: llvm/trunk/test/CodeGen/X86/atom-fixup-lea2.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/atom-fixup-lea2.ll?rev=338342&r1=338341&r2=338342&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/atom-fixup-lea2.ll (original)
+++ llvm/trunk/test/CodeGen/X86/atom-fixup-lea2.ll Mon Jul 30 17:43:54 2018
@@ -1,5 +1,4 @@
 ; RUN: llc < %s -mcpu=atom -mtriple=i686-linux | FileCheck %s
-; RUN: llc < %s -mcpu=goldmont -mtriple=i686-linux | FileCheck %s
 
 ; CHECK:%bb.5
 ; CHECK-NEXT:leal




More information about the llvm-commits mailing list