[PATCH] D49621: [libFuzzer] Initial implementation of weighted mutation leveraging during runtime.

[Jonathan Metzman via Phabricator via llvm-commits]

metzman added inline comments.


================
Comment at: test/fuzzer/fuzzer-weightedmutations.test:4
+# Weighted mutations only trigger after first 10,000 runs, hence flag.
+RUN: not %run %t-WeightedMutationsTest -use_weighted_mutations=1 -runs=100000 2>&1 | FileCheck %s
+
----------------
kodewilliams wrote:
> metzman wrote:
> > Dor1s wrote:
> > > metzman wrote:
> > > > How long does it take to do 100k runs? Does this UnitTest take long?
> > > > 
> > > > Also, what behavior does this test verify? The only thing I can tell is that weighted mutations doesn't crash anything. 
> > > > I think it would be nice to have a test of something more substantial if possible.
> > > +1
> > I think it will be hard to verify some of the behavior that I have observed is broken in this CL with an integration test. You may want to use a unittest for this purpose.
> Real: 0m 0.157s
> User: 0m 0.036s
> Sys: 0m 0.076s
Amount of time LGTM.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49621