[PATCH] D49692: [llvm-mca][docs] Add instruction flow documentation. NFC.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 14:41:13 PDT 2018


mattd added inline comments.


================
Comment at: docs/CommandGuide/llvm-mca.rst:598
+(optimistically) assumes a single register file with an unbounded number of
+temporary registers.  Users can limit the number of temporary registers that
+are globally available for register renaming by using the command option
----------------
andreadb wrote:
> For consistency, please replace every occurrence of `temporary register` with `physical register`. The original RFC used the word "temporary" to describe microarchitectural registers; in code comments, we always use "physical register" instead.
I am happy to make this change to the contents of what is added by this patch.  Elsewhere in the mca docs we mention 'temporary register'.  Notably in mca's command line option `-register-file-size`.  I'm happy to make changes outside of the contents of this patch in a separate patch.   If we change the option documentation, I think that we will also want to change the cl::opt description in the source as well.


https://reviews.llvm.org/D49692





More information about the llvm-commits mailing list