[PATCH] D50007: [LLD] Fix 'ignoring unknown symbol record' message

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

Can you update add a proper class for this symbol?  Even though it's very simple, just having that class there serves as useful documentation of its format.  The steps would be, roughly:

1. Update `CodeViewSymbols.def` and change this from a `CV_SYMBOL` to a `SYMBOL_RECORD`.
2. In `SymbolRecord.h`, add a class for this (looks like it probably has only 1 field).
3. Update `getSymbolNameOffset` function in `RecordName.cpp` to return the correct offset for this symbol.
4. Fix up any compiler errors that occur as a result of needing to implement virtual functions on things that were ignoring this record before.

It should be pretty straightforward with just boilerplate changes.  But after that I think this will be good to go.


Repository:
  rL LLVM

https://reviews.llvm.org/D50007