[PATCH] D50006: [LLD] Fixed crash in type merging

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 14:14:50 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL338308: This fixes a crash when a second pass is required for the Codeview Type merging… (authored by aganea, committed by ).

Repository:
  rL LLVM

https://reviews.llvm.org/D50006

Files:
  llvm/trunk/lib/DebugInfo/CodeView/TypeStreamMerger.cpp


Index: llvm/trunk/lib/DebugInfo/CodeView/TypeStreamMerger.cpp
===================================================================
--- llvm/trunk/lib/DebugInfo/CodeView/TypeStreamMerger.cpp
+++ llvm/trunk/lib/DebugInfo/CodeView/TypeStreamMerger.cpp
@@ -226,7 +226,10 @@
   if (IsSecondPass && MapPos >= Map.size()) {
     // FIXME: Print a more useful error. We can give the current record and the
     // index that we think its pointing to.
-    LastError = joinErrors(std::move(*LastError), errorCorruptRecord());
+    if (LastError)
+      LastError = joinErrors(std::move(*LastError), errorCorruptRecord());
+    else
+      LastError = errorCorruptRecord();
   }
 
   ++NumBadIndices;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50006.158065.patch
Type: text/x-patch
Size: 690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180730/9e19745e/attachment.bin>


More information about the llvm-commits mailing list