[PATCH] D49926: Update split stack support to handle more generic prologues.Improve error handling.Add test file for better code-coverage. Update tests to be morecomplete.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/X86_64.cpp:498
+                        memcmp(Loc, "\x4c\x8d\x9c\x24", 4) == 0)) {
+
+    // The offset bytes are encoded four bytes after the start of the
----------------
nit: remove the empty line.


================
Comment at: ELF/InputSection.cpp:897
+  // unadjustable prologue calls many non-split functions.
+  llvm::DenseSet<Defined *> FailedPrologues;
   std::vector<Relocation *> MorestackCalls;
----------------
Instead of adding another Set, you can just add a symbol with an error as if there was no error occurred to suppress further errors, no?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49926