[PATCH] D49954: [InstCombine] Fold Select with binary op

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 13:30:50 PDT 2018


xbolva00 added a comment.

In https://reviews.llvm.org/D49954#1180981, @spatel wrote:

> In https://reviews.llvm.org/D49954#1180973, @xbolva00 wrote:
>
> > In https://reviews.llvm.org/D49954#1180956, @spatel wrote:
> >
> > > LGTM - are you planning to work on any of the TODO items?
> >
> >
> > Yes.
> >
> > Any advice what should be prioritized from TODO items? Support for undefs?
>
>
> I'd like to have the folds for non-commutative and FP opcodes first. The undef support would be nice, but I think it's much less likely.


Ok, I am going to complete the second fold patch and I would return here again.


https://reviews.llvm.org/D49954





More information about the llvm-commits mailing list