[PATCH] D49985: [ADT] ImmutableList no longer requires elements to be copy constructible

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 12:43:57 PDT 2018


dblaikie added subscribers: Szelethus, dblaikie.
dblaikie added a comment.

Test coverage?

(& also, maybe rather than modifying concat's signature (& causing its
arguments to reverse in a way that might be confusing), just take the
argument by value and move into the destination?)

& does changing these signatures (of concat and add) not break any existing
code?


Repository:
  rL LLVM

https://reviews.llvm.org/D49985





More information about the llvm-commits mailing list