[PATCH] D49964: [DWARF] Refactor DWARF classes to use unified error reporting. NFC.

Mon Jul 30 11:03:20 PDT 2018

vleschuk marked an inline comment as done.
vleschuk added inline comments.

================
Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:27
-
-namespace llvm {   // workaround for gcc bug
-template <>
----------------
wolfgangp wrote:
> vleschuk wrote:
> > JDevlieghere wrote:
> > > vleschuk wrote:
> > > > @wolfgangp I have compiled new code with gcc (7.2.1) and it compiles correctly and passes all tests. Could you please let me know if we can safely get rid of this workaround here?
> > > We officially support GCC 4.8.0 and later, so whether it compiles with 7.2.1 doesn't really tell us much. I believe we have bots running pretty old versions of GCC so you could try removing and see if any of them are failing (or you get complaints from downstream users). 
> > I have tested it, build fails if we just remove this part from code, however everything works fine if we fully apply the patch from this revision and replace calls to createError() with the createStringError(). Tested with clang 6.0, gcc 4.8, 4.9 and 7.2.
> > I have compiled new code with gcc (7.2.1) and it compiles correctly and passes all tests. 
> > Could you please let me know if we can safely get rid of this workaround here?
> 
> It certainly looks like after your changes the workaround is no longer needed since we don't need the explicit specialization of 'createError' any more.
> 
> 
Thanks a lot for confirmation!

Repository:
  rL LLVM

https://reviews.llvm.org/D49964