[PATCH] D49744: [DebugInfo/DWARF] [4/4] De-segregate type units and compile units. NFC

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h:107
 
-/// Describes one section's Units.
+/// Describes a collection of Units. Intended to hold all Units either from
+/// .debug_info and .debug_types, or from .debug_info.dwo and .debug_types.dwo.
----------------
aprantl wrote:
> Why is `Units` capitalized? It's neither a type name and or a concept in DWARF (a compile/type unit is).
Because the old comment had it capitalized.  I will fix it.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h:126
                 DWARFSectionKind SectionKind, bool Lazy = false);
+  unsigned getNumUnits() { return size(); }
+  unsigned getNumInfoUnits() { return NumInfoUnits; }
----------------
aprantl wrote:
> Doxygen comment that explains that this returns all kinds of units?
This entire class hierarchy could use doxygen-izing.


Repository:
  rL LLVM

https://reviews.llvm.org/D49744