[PATCH] D49954: [InstCombine] Fold Select with binary op

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: test/Transforms/InstCombine/select-binop-icmp.ll:174-175
+;
+  %A = icmp eq <2 x i8>  %x, <i8 0, i8 undef>
+  %B = xor <2 x i8>  %x, %z
+  %C = select <2 x i1>  %A, <2 x i8>  %B, <2 x i8>  %y
----------------
xbolva00 wrote:
> spatel wrote:
> > This case should fold, right? Please add a TODO comment here and in the source if that's correct.
> With undef probably not.  
Please explain why not.
This is the only remaining question I have for this patch
cc @lebedev.ri in case there's any other feedback.


https://reviews.llvm.org/D49954