[PATCH] D49938: [ELF] Update ld.lld.1

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 10:23:47 PDT 2018


MaskRay added a comment.

> FWIW I don't have a strong opinion on | vs newline to separate aliases, but if we are going to go with the newline -compact and .Pp approach I'd suggest making that change as a separate commit first so that the actual content changes here are easier to see/review.

Done

> If you do this, always put the short option left of the long one, and decide alphabetic ordering by the short one, not by the long one.

I agree with this rule generally for other software but... for linker options (with a lot of short and long options for various historical heritage, single/double dashes...) I still have the tendency not to prefer unusual short options, e.g. `-h` is a rather uncommon alias of `-soname`
Similarly, I want to put `--strip-debug` before `-S`. `--discard-all` before `-x`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49938





More information about the llvm-commits mailing list