[PATCH] D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a reviewer: vsk.
vsk added a project: debug-info.
vsk added a comment.

> Some lines have a hit counter where they should not have one.
>  For example, in C++, some cleanup is adding at the end of a scope represented by a '}'.
>  So such a line has a hit counter where a user expects to not have one.

Could you share an example of this resulting in an incorrect coverage report?

> The goal of the patch is to add this information in DILocation which is used to get the covered lines in GCOVProfiling.cpp.

This requires adding an operand to DILocation, which is a fairly expensive thing to do. Have you considered any alternatives?

> A following patch in clang will add this information when generating IR (https://reviews.llvm.org/D49916).


Repository:
  rL LLVM

https://reviews.llvm.org/D49915