[PATCH] D49975: [InstSimplify] Fold another Select with And/Or pattern
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 30 10:12:08 PDT 2018
spatel added a comment.
In https://reviews.llvm.org/D49975#1180337, @xbolva00 wrote:
> Any test missing? If ok, I will precommit them.
Tests look good; precommit.
The code logic seems unnecessarily complicated with all of these commuted matches. It would probably be easier to read and shorter if you match a binop with icmp operands and capture all 4 of those operands. Then, make sure the predicates match and make sure there's a common operand from the 4 captured icmp values.
https://reviews.llvm.org/D49975
More information about the llvm-commits
mailing list