[PATCH] D49742: [DebugInfo/DWARF] [2/4] De-segregate type units and compile units. NFC

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

SGTM.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:838
+  DObj->forEachTypesDWOSections(
+      [&](const DWARFSection &S) { DWOTUs.parseDWO(*this, S, DW_SECT_TYPES); });
 }
----------------
Where did the emplace_back go?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:59
                const DWARFSection *AOS, const DWARFSection &LS, bool LE,
                bool IsDWO, bool Lazy, DWARFSectionKind SectionKind) {
   DWARFDataExtractor Data(Obj, Section, LE, 0);
----------------
why is this no longer necessary?


Repository:
  rL LLVM

https://reviews.llvm.org/D49742