[PATCH] D49984: Fix uninitialized read in ARM's PrintAsmOperand

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 07:41:33 PDT 2018


thopre added inline comments.


================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:379
         const TargetRegisterInfo *TRI = MF->getSubtarget().getRegisterInfo();
         unsigned Reg = TRI->getSubReg(MO.getReg(), ExtraCode[0] == 'Q' ?
             ARM::gsub_0 : ARM::gsub_1);
----------------
chill wrote:
> Is this doing the right thing for big-endian? (re: https://reviews.llvm.org/D49778)
> (arguably a slightly separate issue, indeed).
Apparently not but this is an independent problem (ie. the patch does not touch this) and would be fixed by Jackson's patch. Do you mean that Jackson's patch should go in first and be marked as a dependency of this one?


Repository:
  rL LLVM

https://reviews.llvm.org/D49984





More information about the llvm-commits mailing list