[PATCH] D49611: [X86] Improved sched models for X86 SHLD/SHRD* instructions

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.

LGTM with a couple of minors - cheers



================
Comment at: lib/Target/X86/X86Schedule.td:148
 defm WriteShift : X86SchedWritePair;
-// Double shift instructions.
-defm WriteShiftDouble : X86SchedWritePair;
+def  WriteSHDrri  : SchedWrite;
+def  WriteSHDrrcl : SchedWrite;
----------------
Keep the // Double shift instructions. comment here


================
Comment at: lib/Target/X86/X86ScheduleAtom.td:153
 
-////////////////////////////////////////////////////////////////////////////////
-// Double shift instructions.
-////////////////////////////////////////////////////////////////////////////////
-
-defm : AtomWriteResPair<WriteShiftDouble, [AtomPort0], [AtomPort0]>;
+// SHLD/SHRD (32-bit versions).
+defm : X86WriteRes<WriteSHDrri, [AtomPort01], 2, [2], 1>;
----------------
No need for the 32-bit comment - we don't do this for any other override cases.


https://reviews.llvm.org/D49611